fix: resize observer loop limit exception #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Kibana, we start getting error messages in TSVB describing that the ResizeObserver has reached the loop limit when used togheter with react-beautiful-dnd library. This fix the issue in Kibana updating the state on the next frame instead of the current one. fix elastic/kibana#48589
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
=======================================
Coverage 97.85% 97.85%
=======================================
Files 39 39
Lines 2896 2896
Branches 701 701
=======================================
Hits 2834 2834
Misses 55 55
Partials 7 7Continue to review full report at Codecov.
|
nickofthyme
approved these changes
Oct 21, 2019
markov00
pushed a commit
that referenced
this pull request
Oct 22, 2019
## [13.5.5](v13.5.4...v13.5.5) (2019-10-22) ### Bug Fixes * resize observer loop limit exception ([#429](#429)) ([5243ef3](5243ef3))
|
🎉 This PR is included in version 13.5.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [13.5.5](elastic/elastic-charts@v13.5.4...v13.5.5) (2019-10-22) ### Bug Fixes * resize observer loop limit exception ([opensearch-project#429](elastic/elastic-charts#429)) ([c92101f](elastic/elastic-charts@c92101f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Kibana, we start getting error messages in TSVB describing that the ResizeObserver has reached the loop limit when used together with react-beautiful-dnd library (used by EUI). This fix the issue in Kibana updating the state in the next frame instead of the current one.
fix elastic/kibana#48589
I don't have found the root cause of that. I've found that the error disappear in Kibana in two way:
references:
WICG/resize-observer#38
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any consumer-facing exports were added tosrc/index.ts(and stories only import from../srcexcept for test data & storybook)[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Proper documentation or storybook story was added for features that require explanation or tutorials